Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-08-09 06:48:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

more interface-only spaghetti out of Avatar

Browse source
This commit is contained in:
Andrew Meadows 2017-04-11 13:11:11 -07:00
parent 272cf07c31
commit 9cddbbc42a
3 changed files with 10 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
interface/src/Application.cpp
View file

@ -2440,7 +2440,7 @@ void Application::resizeGL() {
// Possible change in aspect ratio // Possible change in aspect ratio
{ {
QMutexLocker viewLocker(&_viewMutex); QMutexLocker viewLocker(&_viewMutex);
loadViewFrustum(_myCamera, _viewFrustum); _myCamera.loadViewFrustum(_viewFrustum);
} }
auto offscreenUi = DependencyManager::get<OffscreenUi>(); auto offscreenUi = DependencyManager::get<OffscreenUi>();
@ -4525,7 +4525,7 @@ void Application::update(float deltaTime) {
// to the server. // to the server.
{ {
QMutexLocker viewLocker(&_viewMutex); QMutexLocker viewLocker(&_viewMutex);
loadViewFrustum(_myCamera, _viewFrustum); _myCamera.loadViewFrustum(_viewFrustum);
} }
quint64 now = usecTimestampNow(); quint64 now = usecTimestampNow();
@ -4853,24 +4853,6 @@ QRect Application::getDesirableApplicationGeometry() const {
return applicationGeometry; return applicationGeometry;
} }
/////////////////////////////////////////////////////////////////////////////////////
// loadViewFrustum()
//
// Description: this will load the view frustum bounds for EITHER the head
// or the "myCamera".
//
void Application::loadViewFrustum(Camera& camera, ViewFrustum& viewFrustum) {
// We will use these below, from either the camera or head vectors calculated above
viewFrustum.setProjection(camera.getProjection());
// Set the viewFrustum up with the correct position and orientation of the camera
viewFrustum.setPosition(camera.getPosition());
viewFrustum.setOrientation(camera.getOrientation());
// Ask the ViewFrustum class to calculate our corners
viewFrustum.calculate();
}
glm::vec3 Application::getSunDirection() const { glm::vec3 Application::getSunDirection() const {
// Sun direction is in fact just the location of the sun relative to the origin // Sun direction is in fact just the location of the sun relative to the origin
auto skyStage = DependencyManager::get<SceneScriptingInterface>()->getSkyStage(); auto skyStage = DependencyManager::get<SceneScriptingInterface>()->getSkyStage();
@ -5042,7 +5024,7 @@ void Application::displaySide(RenderArgs* renderArgs, Camera& theCamera, bool se
// load the view frustum // load the view frustum
{ {
QMutexLocker viewLocker(&_viewMutex); QMutexLocker viewLocker(&_viewMutex);
loadViewFrustum(theCamera, _displayViewFrustum); theCamera.loadViewFrustum(_displayViewFrustum);
} }
// TODO fix shadows and make them use the GPU library // TODO fix shadows and make them use the GPU library
@ -5059,7 +5041,7 @@ void Application::displaySide(RenderArgs* renderArgs, Camera& theCamera, bool se
transaction.resetItem(BackgroundRenderData::_item, backgroundRenderPayload); transaction.resetItem(BackgroundRenderData::_item, backgroundRenderPayload);
} }
// Assuming nothing get's rendered through that // Assuming nothing gets rendered through that
if (!selfAvatarOnly) { if (!selfAvatarOnly) {
if (DependencyManager::get<SceneScriptingInterface>()->shouldRenderEntities()) { if (DependencyManager::get<SceneScriptingInterface>()->shouldRenderEntities()) {
// render models... // render models...

1
interface/src/Application.h
View file

@ -462,7 +462,6 @@ private:
void updateDialogs(float deltaTime) const; void updateDialogs(float deltaTime) const;
void queryOctree(NodeType_t serverType, PacketType packetType, NodeToJurisdictionMap& jurisdictions, bool forceResend = false); void queryOctree(NodeType_t serverType, PacketType packetType, NodeToJurisdictionMap& jurisdictions, bool forceResend = false);
static void loadViewFrustum(Camera& camera, ViewFrustum& viewFrustum);
glm::vec3 getSunDirection() const; glm::vec3 getSunDirection() const;

17
interface/src/avatar/Avatar.cpp
View file

@ -71,6 +71,7 @@ namespace render {
auto avatarPtr = static_pointer_cast<Avatar>(avatar); auto avatarPtr = static_pointer_cast<Avatar>(avatar);
if (avatarPtr->isInitialized() && args) { if (avatarPtr->isInitialized() && args) {
PROFILE_RANGE_BATCH(*args->_batch, "renderAvatarPayload"); PROFILE_RANGE_BATCH(*args->_batch, "renderAvatarPayload");
// TODO AVATARS_RENDERER: remove need for qApp
avatarPtr->render(args, qApp->getMain3DScene(), qApp->getCamera()); avatarPtr->render(args, qApp->getMain3DScene(), qApp->getCamera());
} }
} }
@ -641,19 +642,12 @@ void Avatar::render(RenderArgs* renderArgs, render::ScenePointer scene, const Ca
} }
} }
{ // simple frustum check ViewFrustum frustum = renderArgs->getViewFrustum();
ViewFrustum frustum; if (!frustum.sphereIntersectsFrustum(getPosition(), getBoundingRadius())) {
if (renderArgs->_renderMode == RenderArgs::SHADOW_RENDER_MODE) { return;
qApp->copyShadowViewFrustum(frustum);
} else {
qApp->copyDisplayViewFrustum(frustum);
}
if (!frustum.sphereIntersectsFrustum(getPosition(), getBoundingRadius())) {
return;
}
} }
glm::vec3 toTarget = camera.getPosition() - getPosition(); glm::vec3 toTarget = frustum.getPosition() - getPosition();
float distanceToTarget = glm::length(toTarget); float distanceToTarget = glm::length(toTarget);
{ {
@ -686,6 +680,7 @@ void Avatar::render(RenderArgs* renderArgs, render::ScenePointer scene, const Ca
const float DISPLAYNAME_DISTANCE = 20.0f; const float DISPLAYNAME_DISTANCE = 20.0f;
setShowDisplayName(distanceToTarget < DISPLAYNAME_DISTANCE); setShowDisplayName(distanceToTarget < DISPLAYNAME_DISTANCE);
// TODO AVATARS_RENDERER: remove need for 'camera' in this context
auto cameraMode = camera.getMode(); auto cameraMode = camera.getMode();
if (!isMyAvatar() || cameraMode != CAMERA_MODE_FIRST_PERSON) { if (!isMyAvatar() || cameraMode != CAMERA_MODE_FIRST_PERSON) {
auto& frustum = renderArgs->getViewFrustum(); auto& frustum = renderArgs->getViewFrustum();