Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-04-07 10:02:24 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Removed unnecessary member variable.

Browse source
This commit is contained in:
NissimHadar 2019-02-14 10:38:19 -08:00
parent 701c18c9eb
commit 6752092899
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tools/nitpick/src/AWSInterface.cpp
View file

@ -33,7 +33,6 @@ void AWSInterface::createWebPageFromResults(const QString& testResults,
// For example `D:/tt/TestResults--2019-02-10_17-30-57(local)[DESKTOP-6BO62Q9].zip`
QStringList parts = testResults.split('/');
QString zipFilename = parts[parts.length() - 1];
_zipFolderName = _workingDirectory + "/" + zipFilename.split('.')[0];
QStringList zipFolderNameParts = zipFilename.split(QRegExp("[\\(\\)\\[\\]]"), QString::SkipEmptyParts);
@ -50,7 +49,8 @@ void AWSInterface::createWebPageFromResults(const QString& testResults,
_urlLineEdit = urlLineEdit;
_urlLineEdit->setEnabled(false);
extractTestFailuresFromZippedFolder();
QString zipFilenameWithoutExtension = zipFilename.split('.')[0];
extractTestFailuresFromZippedFolder(_workingDirectory + "/" + zipFilenameWithoutExtension);
createHTMLFile();
if (updateAWSCheckBox->isChecked()) {
@ -61,12 +61,12 @@ void AWSInterface::createWebPageFromResults(const QString& testResults,
}
}
void AWSInterface::extractTestFailuresFromZippedFolder() {
void AWSInterface::extractTestFailuresFromZippedFolder(const QString& folderName) {
// For a test results zip file called `D:/tt/TestResults--2018-10-02_16-54-11(9426)[DESKTOP-PMKNLSQ].zip`
// the folder will be called `TestResults--2018-10-02_16-54-11(9426)[DESKTOP-PMKNLSQ]`
// and, this folder will be in the working directory
if (QDir(_zipFolderName).exists()) {
QDir dir = _zipFolderName;
if (QDir(folderName).exists()) {
QDir dir = folderName;
dir.removeRecursively();
}

3
tools/nitpick/src/AWSInterface.h
View file

@ -30,7 +30,7 @@ public:
QCheckBox* updateAWSCheckBox,
QLineEdit* urlLineEdit);
void extractTestFailuresFromZippedFolder();
void extractTestFailuresFromZippedFolder(const QString& folderName);
void createHTMLFile();
void startHTMLpage(QTextStream& stream);
@ -49,7 +49,6 @@ public:
private:
QString _testResults;
QString _zipFolderName;
QString _workingDirectory;
QString _resultsFolder;
QString _htmlFailuresFolder;