diff --git a/tools/nitpick/src/Nitpick.cpp b/tools/nitpick/src/Nitpick.cpp
index 880ea10620..dc9a6c605d 100644
--- a/tools/nitpick/src/Nitpick.cpp
+++ b/tools/nitpick/src/Nitpick.cpp
@@ -48,8 +48,12 @@ Nitpick::~Nitpick() {
delete _test;
}
- if (_testRunner) {
- delete _testRunner;
+ if (_testRunnerDesktop) {
+ delete _testRunnerDesktop;
+ }
+
+ if (_testRunnerMobile) {
+ delete _testRunnerMobile;
}
}
@@ -80,10 +84,16 @@ void Nitpick::setup() {
timeEdits.emplace_back(_ui.timeEdit3);
timeEdits.emplace_back(_ui.timeEdit4);
- if (_testRunner) {
- delete _testRunner;
+ // Create the two test runners
+ if (_testRunnerDesktop) {
+ delete _testRunnerDesktop;
}
- _testRunner = new TestRunnerDesktop(dayCheckboxes, timeEditCheckboxes, timeEdits, _ui.workingFolderLabel, _ui.checkBoxServerless, _ui.checkBoxRunLatest, _ui.urlLineEdit, _ui.runNowButton);
+ _testRunnerDesktop = new TestRunnerDesktop(dayCheckboxes, timeEditCheckboxes, timeEdits, _ui.workingFolderRunOnDesktopLabel, _ui.checkBoxServerless, _ui.checkBoxRunLatest, _ui.urlLineEdit, _ui.runNowButton);
+
+ if (_testRunnerMobile) {
+ delete _testRunnerMobile;
+ }
+ _testRunnerMobile = new TestRunnerMobile();
}
void Nitpick::startTestsEvaluation(const bool isRunningFromCommandLine,
@@ -154,8 +164,8 @@ void Nitpick::on_createTestRailRunButton_clicked() {
_test->createTestRailRun();
}
-void Nitpick::on_setWorkingFolderButton_clicked() {
- _testRunner->setWorkingFolder();
+void Nitpick::on_setWorkingFolderRunOnDesktopButton_clicked() {
+ _testRunnerDesktop->setWorkingFolder();
}
void Nitpick::enableRunTabControls() {
@@ -165,7 +175,7 @@ void Nitpick::enableRunTabControls() {
}
void Nitpick::on_runNowButton_clicked() {
- _testRunner->run();
+ _testRunnerDesktop->run();
}
void Nitpick::on_checkBoxRunLatest_clicked() {
@@ -173,7 +183,7 @@ void Nitpick::on_checkBoxRunLatest_clicked() {
}
void Nitpick::automaticTestRunEvaluationComplete(QString zippedFolderName, int numberOfFailures) {
- _testRunner->automaticTestRunEvaluationComplete(zippedFolderName, numberOfFailures);
+ _testRunnerDesktop->automaticTestRunEvaluationComplete(zippedFolderName, numberOfFailures);
}
void Nitpick::on_updateTestRailRunResultsButton_clicked() {
@@ -273,8 +283,8 @@ void Nitpick::saveFile(int index) {
disconnect(_signalMapper, SIGNAL(mapped(int)), this, SLOT(saveFile(int)));
if (_caller == _test) {
_test->finishTestsEvaluation();
- } else if (_caller == _testRunner) {
- _testRunner->downloadComplete();
+ } else if (_caller == _testRunnerDesktop) {
+ _testRunnerDesktop->downloadComplete();
}
} else {
_ui.progressBar->setValue(_numberOfFilesDownloaded);
@@ -312,3 +322,6 @@ void Nitpick::updateStatusLabel(const QString& status) {
void Nitpick::appendLogWindow(const QString& message) {
_ui.plainTextEdit->appendPlainText(message);
}
+
+void Nitpick::on_setWorkingFolderRunOnMobileButton_clicked() {
+}
diff --git a/tools/nitpick/src/Nitpick.h b/tools/nitpick/src/Nitpick.h
index 85e049936e..64a8e5c480 100644
--- a/tools/nitpick/src/Nitpick.h
+++ b/tools/nitpick/src/Nitpick.h
@@ -19,6 +19,8 @@
#include "Test.h"
#include "TestRunnerDesktop.h"
+#include "TestRunnerMobile.h"
+
#include "AWSInterface.h"
class Nitpick : public QMainWindow {
@@ -71,9 +73,11 @@ private slots:
void on_createTestRailTestCasesButton_clicked();
void on_createTestRailRunButton_clicked();
- void on_setWorkingFolderButton_clicked();
+ void on_setWorkingFolderRunOnDesktopButton_clicked();
void on_runNowButton_clicked();
+ void on_setWorkingFolderRunOnMobileButton_clicked();
+
void on_checkBoxRunLatest_clicked();
void on_updateTestRailRunResultsButton_clicked();
@@ -96,7 +100,9 @@ private slots:
private:
Ui::NitpickClass _ui;
Test* _test{ nullptr };
- TestRunnerDesktop* _testRunner{ nullptr };
+
+ TestRunnerDesktop* _testRunnerDesktop{ nullptr };
+ TestRunnerMobile* _testRunnerMobile{ nullptr };
AWSInterface _awsInterface;
diff --git a/tools/nitpick/src/TestRunnerMobile.h b/tools/nitpick/src/TestRunnerMobile.h
index f38ad5f5fe..50e17b64b9 100644
--- a/tools/nitpick/src/TestRunnerMobile.h
+++ b/tools/nitpick/src/TestRunnerMobile.h
@@ -15,7 +15,7 @@
class TestRunnerMobile : public QObject {
Q_OBJECT
public:
- explicit TestRunnerMobile(QObject* parent);
+ explicit TestRunnerMobile(QObject* parent = 0);
~TestRunnerMobile();
};
#endif
diff --git a/tools/nitpick/ui/Nitpick.ui b/tools/nitpick/ui/Nitpick.ui
index 6a5e5faa27..e935c28e00 100644
--- a/tools/nitpick/ui/Nitpick.ui
+++ b/tools/nitpick/ui/Nitpick.ui
@@ -43,7 +43,7 @@
- 3
+ 2
@@ -420,26 +420,26 @@
-
+
10
20
- 161
- 28
+ 160
+ 30
Set Working Folder
-
+
190
20
- 321
- 31
+ 320
+ 30
@@ -551,6 +551,58 @@
Run on Device
+
+
+
+ 10
+ 100
+ 160
+ 30
+
+
+
+ Get Device
+
+
+
+
+
+ 190
+ 100
+ 230
+ 20
+
+
+
+ (not detected)
+
+
+
+
+
+ 10
+ 20
+ 160
+ 30
+
+
+
+ Set Working Folder
+
+
+
+
+
+ 190
+ 20
+ 320
+ 30
+
+
+
+ (not set...)
+
+
@@ -882,7 +934,7 @@
timeEdit2checkBox
timeEdit3checkBox
timeEdit4checkBox
- setWorkingFolderButton
+ setWorkingFolderRunOnDesktopButton
plainTextEdit
checkBoxServerless
checkBoxRunLatest