CR feedback

Though this seems like a hard place to remember, when we make further
changes.
This commit is contained in:
David Kelly 2016-12-19 17:23:24 -08:00
parent 5b9c19b39e
commit 4feec85337
2 changed files with 3 additions and 9 deletions

View file

@ -44,7 +44,7 @@ const QSet<PacketType> NON_SOURCED_PACKETS = QSet<PacketType>()
PacketVersion versionForPacketType(PacketType packetType) { PacketVersion versionForPacketType(PacketType packetType) {
switch (packetType) { switch (packetType) {
case PacketType::DomainList: case PacketType::DomainList:
return static_cast<PacketVersion>(DomainListVersion::GetUsernameFromUUIDSupport); return static_cast<PacketVersion>(DomainListVersion::GetMachineFingerprintFromUUIDSupport);
case PacketType::EntityAdd: case PacketType::EntityAdd:
case PacketType::EntityEdit: case PacketType::EntityEdit:
case PacketType::EntityData: case PacketType::EntityData:
@ -80,9 +80,6 @@ PacketVersion versionForPacketType(PacketType packetType) {
case PacketType::AudioStreamStats: case PacketType::AudioStreamStats:
return static_cast<PacketVersion>(AudioVersion::SpaceBubbleChanges); return static_cast<PacketVersion>(AudioVersion::SpaceBubbleChanges);
case PacketType::UsernameFromIDReply:
return static_cast<PacketVersion>(UsernameFromIDReplyVersion::HasMachineFingerprint);
default: default:
return 17; return 17;
} }

View file

@ -230,7 +230,8 @@ enum class DomainServerAddedNodeVersion : PacketVersion {
enum class DomainListVersion : PacketVersion { enum class DomainListVersion : PacketVersion {
PrePermissionsGrid = 18, PrePermissionsGrid = 18,
PermissionsGrid, PermissionsGrid,
GetUsernameFromUUIDSupport GetUsernameFromUUIDSupport,
GetMachineFingerprintFromUUIDSupport
}; };
enum class AudioVersion : PacketVersion { enum class AudioVersion : PacketVersion {
@ -241,8 +242,4 @@ enum class AudioVersion : PacketVersion {
SpaceBubbleChanges, SpaceBubbleChanges,
}; };
enum class UsernameFromIDReplyVersion : PacketVersion {
HasMachineFingerprint = 18
};
#endif // hifi_PacketHeaders_h #endif // hifi_PacketHeaders_h