Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-08-09 09:37:14 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

CR feedback

Browse source
This commit is contained in:
ZappoMan 2013-08-21 13:09:51 -07:00
parent 4bdaf7589f
commit 4fd23a0cd9
5 changed files with 11 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
animation-server/src/main.cpp
View file

@ -651,27 +651,27 @@ int main(int argc, const char * argv[])
// Handle Local Domain testing with the --local command line // Handle Local Domain testing with the --local command line
const char* NO_BILLBOARD = "--NoBillboard"; const char* NO_BILLBOARD = "--NoBillboard";
::includeBillboard = !cmdOptionExists(argc, argv, NO_BILLBOARD); ::includeBillboard = !cmdOptionExists(argc, argv, NO_BILLBOARD);
printf("includeBillboard=%s\n",debug::valueOf(::includeBillboard)); printf("includeBillboard=%s\n", debug::valueOf(::includeBillboard));
const char* NO_BORDER_TRACER = "--NoBorderTracer"; const char* NO_BORDER_TRACER = "--NoBorderTracer";
::includeBorderTracer = !cmdOptionExists(argc, argv, NO_BORDER_TRACER); ::includeBorderTracer = !cmdOptionExists(argc, argv, NO_BORDER_TRACER);
printf("includeBorderTracer=%s\n",debug::valueOf(::includeBorderTracer)); printf("includeBorderTracer=%s\n", debug::valueOf(::includeBorderTracer));
const char* NO_MOVING_BUG = "--NoMovingBug"; const char* NO_MOVING_BUG = "--NoMovingBug";
::includeMovingBug = !cmdOptionExists(argc, argv, NO_MOVING_BUG); ::includeMovingBug = !cmdOptionExists(argc, argv, NO_MOVING_BUG);
printf("includeMovingBug=%s\n",debug::valueOf(::includeMovingBug)); printf("includeMovingBug=%s\n", debug::valueOf(::includeMovingBug));
const char* INCLUDE_BLINKING_VOXEL = "--includeBlinkingVoxel"; const char* INCLUDE_BLINKING_VOXEL = "--includeBlinkingVoxel";
::includeBlinkingVoxel = cmdOptionExists(argc, argv, INCLUDE_BLINKING_VOXEL); ::includeBlinkingVoxel = cmdOptionExists(argc, argv, INCLUDE_BLINKING_VOXEL);
printf("includeBlinkingVoxel=%s\n",debug::valueOf(::includeBlinkingVoxel)); printf("includeBlinkingVoxel=%s\n", debug::valueOf(::includeBlinkingVoxel));
const char* NO_DANCE_FLOOR = "--NoDanceFloor"; const char* NO_DANCE_FLOOR = "--NoDanceFloor";
::includeDanceFloor = !cmdOptionExists(argc, argv, NO_DANCE_FLOOR); ::includeDanceFloor = !cmdOptionExists(argc, argv, NO_DANCE_FLOOR);
printf("includeDanceFloor=%s\n",debug::valueOf(::includeDanceFloor)); printf("includeDanceFloor=%s\n", debug::valueOf(::includeDanceFloor));
const char* BUILD_STREET = "--BuildStreet"; const char* BUILD_STREET = "--BuildStreet";
::buildStreet = cmdOptionExists(argc, argv, BUILD_STREET); ::buildStreet = cmdOptionExists(argc, argv, BUILD_STREET);
printf("buildStreet=%s\n",debug::valueOf(::buildStreet)); printf("buildStreet=%s\n", debug::valueOf(::buildStreet));
// Handle Local Domain testing with the --local command line // Handle Local Domain testing with the --local command line
const char* showPPS = "--showPPS"; const char* showPPS = "--showPPS";

1
libraries/voxels/src/JurisdictionMap.cpp
View file

@ -235,7 +235,6 @@ int JurisdictionMap::packIntoMessage(unsigned char* destinationBuffer, int avail
// add the root jurisdiction // add the root jurisdiction
if (_rootOctalCode) { if (_rootOctalCode) {
// copy the
int bytes = bytesRequiredForCodeLength(numberOfThreeBitSectionsInCode(_rootOctalCode)); int bytes = bytesRequiredForCodeLength(numberOfThreeBitSectionsInCode(_rootOctalCode));
memcpy(destinationBuffer, &bytes, sizeof(bytes)); memcpy(destinationBuffer, &bytes, sizeof(bytes));
destinationBuffer += sizeof(bytes); destinationBuffer += sizeof(bytes);

6
libraries/voxels/src/JurisdictionSender.cpp
View file

@ -39,11 +39,7 @@ bool JurisdictionSender::process() {
bool continueProcessing = isStillRunning(); bool continueProcessing = isStillRunning();
// call our ReceivedPacketProcessor base class process so we'll get any pending packets // call our ReceivedPacketProcessor base class process so we'll get any pending packets
if (continueProcessing) { if (continueProcessing && (continueProcessing = ReceivedPacketProcessor::process())) {
continueProcessing = ReceivedPacketProcessor::process();
}
if (continueProcessing) {
// add our packet to our own queue, then let the PacketSender class do the rest of the work. // add our packet to our own queue, then let the PacketSender class do the rest of the work.
static unsigned char buffer[MAX_PACKET_SIZE]; static unsigned char buffer[MAX_PACKET_SIZE];
unsigned char* bufferOut = &buffer[0]; unsigned char* bufferOut = &buffer[0];

3
libraries/voxels/src/VoxelSceneStats.h
View file

@ -119,10 +119,11 @@ public:
}; };
/// Returns details about items tracked by VoxelSceneStats /// Returns details about items tracked by VoxelSceneStats
/// \param /// \param Item item The item from the stats you're interested in.
ItemInfo& getItemInfo(Item item) { return _ITEMS[item]; }; ItemInfo& getItemInfo(Item item) { return _ITEMS[item]; };
/// Returns a UI formatted value of an item tracked by VoxelSceneStats /// Returns a UI formatted value of an item tracked by VoxelSceneStats
/// \param Item item The item from the stats you're interested in.
char* getItemValue(Item item); char* getItemValue(Item item);
/// Returns OctCode for root node of the jurisdiction of this particular voxel server /// Returns OctCode for root node of the jurisdiction of this particular voxel server

5
voxel-server/src/main.cpp
View file

@ -510,9 +510,8 @@ int main(int argc, const char * argv[]) {
NodeList* nodeList = NodeList::createInstance(NODE_TYPE_VOXEL_SERVER, listenPort); NodeList* nodeList = NodeList::createInstance(NODE_TYPE_VOXEL_SERVER, listenPort);
setvbuf(stdout, NULL, _IOLBF, 0); setvbuf(stdout, NULL, _IOLBF, 0);
const int numNodeTypes = 2; const NODE_TYPE nodeTypes[] = { NODE_TYPE_AGENT, NODE_TYPE_ANIMATION_SERVER };
const NODE_TYPE nodeTypes[numNodeTypes] = { NODE_TYPE_AGENT, NODE_TYPE_ANIMATION_SERVER }; NodeList::getInstance()->setNodeTypesOfInterest(&nodeTypes[0], sizeof(nodeTypes));
NodeList::getInstance()->setNodeTypesOfInterest(&nodeTypes[0], numNodeTypes);
// Handle Local Domain testing with the --local command line // Handle Local Domain testing with the --local command line
const char* local = "--local"; const char* local = "--local";