From 37d694afa0165f7ce5aa15aa2597929a585c528f Mon Sep 17 00:00:00 2001 From: Alezia Kurdis <60075796+AleziaKurdis@users.noreply.github.com> Date: Tue, 6 Oct 2020 22:05:39 -0400 Subject: [PATCH] Minor Code Adjustments Minor Code Adjustments --- .../create/entitySelectionTool/entitySelectionTool.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/system/create/entitySelectionTool/entitySelectionTool.js b/scripts/system/create/entitySelectionTool/entitySelectionTool.js index 51608a2d87..007f253943 100644 --- a/scripts/system/create/entitySelectionTool/entitySelectionTool.js +++ b/scripts/system/create/entitySelectionTool/entitySelectionTool.js @@ -319,7 +319,7 @@ SelectionManager = (function() { that.addChildrenEntities(originalEntityID, entitiesToDuplicate, entityHostTypes[i].entityHostType); } - var hasItFailed = false; + var duplicateInterrupted = false; // duplicate entities from above and store their original to new entity mappings and children needing re-parenting for (var i = 0; i < entitiesToDuplicate.length; i++) { var originalEntityID = entitiesToDuplicate[i]; @@ -367,7 +367,7 @@ SelectionManager = (function() { } originalEntityToNewEntityID[originalEntityID] = newEntityID; } else { - hasItFailed = true; + duplicateInterrupted = true; } } @@ -386,10 +386,10 @@ SelectionManager = (function() { } }); - if (!hasItFailed) { - audioFeedback.confirmation(); - } else { + if (duplicateInterrupted) { audioFeedback.rejection(); + } else { + audioFeedback.confirmation(); } return duplicatedEntityIDs; };