From 35f5ebb93829885694e78de20677256a85d38d60 Mon Sep 17 00:00:00 2001
From: Atlante45 <clement.brisset@gmail.com>
Date: Thu, 10 Mar 2016 15:50:02 -0800
Subject: [PATCH] Don't allow folder overwrite

---
 interface/resources/qml/AssetServer.qml             |  8 ++++++--
 .../scripting/AssetMappingsScriptingInterface.cpp   | 13 +++++++++++++
 .../src/scripting/AssetMappingsScriptingInterface.h |  6 ++++--
 3 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/interface/resources/qml/AssetServer.qml b/interface/resources/qml/AssetServer.qml
index afb4b50773..768eaa28a2 100644
--- a/interface/resources/qml/AssetServer.qml
+++ b/interface/resources/qml/AssetServer.qml
@@ -72,12 +72,16 @@ Window {
 
     }
     function doRenameFile(oldPath, newPath) {
-        console.log("Renaming " + oldPath + " to " + newPath);
-
         if (newPath[0] != "/") {
             newPath = "/" + newPath;
         }
 
+        if (Assets.isKnownFolder(newPath)) {
+            box = errorMessageBox("Cannot override existing directory.");
+            box.selected.connect(reload);
+        }
+
+        console.log("Renaming " + oldPath + " to " + newPath);
         Assets.renameMapping(oldPath, newPath, function(err) {
             if (err) {
                 console.log("Error renaming: ", oldPath, "=>", newPath, " - error ", err);
diff --git a/interface/src/scripting/AssetMappingsScriptingInterface.cpp b/interface/src/scripting/AssetMappingsScriptingInterface.cpp
index 6ac60ccbdf..ae2ef3183a 100644
--- a/interface/src/scripting/AssetMappingsScriptingInterface.cpp
+++ b/interface/src/scripting/AssetMappingsScriptingInterface.cpp
@@ -174,6 +174,19 @@ void AssetMappingsScriptingInterface::renameMapping(QString oldPath, QString new
     request->start();
 }
 
+bool AssetMappingModel::isKnownFolder(QString path) const {
+    if (!path.endsWith("/")) {
+        return false;
+    }
+
+    auto existingPaths = _pathToItemMap.keys();
+    for (auto& entry : existingPaths) {
+        if (entry.startsWith(path)) {
+            return true;
+        }
+    }
+    return false;
+}
 
 AssetMappingItem::AssetMappingItem(const QString& name, const QString& fullPath, bool isFolder) :
     name(name),
diff --git a/interface/src/scripting/AssetMappingsScriptingInterface.h b/interface/src/scripting/AssetMappingsScriptingInterface.h
index 3a7711b340..99ced25d29 100644
--- a/interface/src/scripting/AssetMappingsScriptingInterface.h
+++ b/interface/src/scripting/AssetMappingsScriptingInterface.h
@@ -35,7 +35,8 @@
  public:
      Q_INVOKABLE void refresh();
 
-     bool isKnownMapping(QString path) const { return _pathToItemMap.contains(path); };
+     bool isKnownMapping(QString path) const { return _pathToItemMap.contains(path); }
+     bool isKnownFolder(QString path) const;
 
  signals:
      void errorGettingMappings(int error);
@@ -55,7 +56,8 @@ public:
     Q_INVOKABLE AssetMappingModel* getAssetMappingModel() { return &_assetMappingModel; }
     Q_INVOKABLE QAbstractProxyModel* getProxyModel() { return &_proxyModel; }
 
-    Q_INVOKABLE bool isKnownMapping(QString path) const { return _assetMappingModel.isKnownMapping(path); };
+    Q_INVOKABLE bool isKnownMapping(QString path) const { return _assetMappingModel.isKnownMapping(path); }
+    Q_INVOKABLE bool isKnownFolder(QString path) const { return _assetMappingModel.isKnownFolder(path); }
 
     Q_INVOKABLE QString getErrorString(int errorCode) const;