Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-08-09 14:47:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Allow more image names to be used as Nitpick test reference images

Browse source
This commit is contained in:
sabrina-shanman 2019-08-21 14:08:47 -07:00
parent 1011880698
commit 2dbf3de58a
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tools/nitpick/src/TestCreator.cpp
View file

@ -323,9 +323,11 @@ void TestCreator::startTestsEvaluation(
QString expectedImagePartialSourceDirectory = getExpectedImagePartialSourceDirectory(currentFilename); QString expectedImagePartialSourceDirectory = getExpectedImagePartialSourceDirectory(currentFilename);
// Images are stored on GitHub as ExpectedImage_ddddd.png // Images are stored on GitHub as ExpectedImage_ddddd.png or ExpectedImage_some_metadata_ddddd.png
// Extract the digits at the end of the filename (excluding the file extension) // Extract the part of the filename after "ExpectedImage_" and excluding the file extension
QString expectedImageFilenameTail = currentFilename.left(currentFilename.length() - 4).right(NUM_DIGITS); QString expectedImageFilenameTail = currentFilename.left(currentFilename.lastIndexOf("."));
int expectedImageStart = expectedImageFilenameTail.lastIndexOf(".") + 1;
expectedImageFilenameTail.remove(0, expectedImageStart);
QString expectedImageStoredFilename = EXPECTED_IMAGE_PREFIX + expectedImageFilenameTail + ".png"; QString expectedImageStoredFilename = EXPECTED_IMAGE_PREFIX + expectedImageFilenameTail + ".png";
QString imageURLString("https://raw.githubusercontent.com/" + user + "/" + GIT_HUB_REPOSITORY + "/" + branch + "/" + QString imageURLString("https://raw.githubusercontent.com/" + user + "/" + GIT_HUB_REPOSITORY + "/" + branch + "/" +