Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-04-06 05:03:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use non-secret environment variable for PR build crash reporting

Browse source
This commit is contained in:
Dale Glass 2023-06-07 23:48:46 +02:00
parent e8fbb98ab6
commit 258e1de181
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/linux_server_build.yml vendored
View file

@ -19,7 +19,7 @@ env:
UPLOAD_BUCKET: overte-public
UPLOAD_REGION: fra1
UPLOAD_ENDPOINT: "https://fra1.digitaloceanspaces.com"
CMAKE_BACKTRACE_URL: ${{ secrets.SENTRY_MINIDUMP_ENDPOINT }}
CMAKE_BACKTRACE_URL: ${{ secrets.SENTRY_MINIDUMP_ENDPOINT || vars.SENTRY_PR_MINIDUMP_ENDPOINT }}
CMAKE_BACKTRACE_TOKEN: server_${{ github.event.number }}_${{ github.sha }}
jobs:

4
.github/workflows/pr_build.yml vendored
View file

@ -21,7 +21,9 @@ env:
RELEASE_NUMBER: ${{ github.event.number }}
VERSION_CODE: ${{ github.event.number }}
# Sentry Crash Reporting
CMAKE_BACKTRACE_URL: ${{ secrets.SENTRY_MINIDUMP_ENDPOINT }}
# We use a variable rather than a secret here -- this makes the URL more exposed, so there's some risk of somebody
# using it for no good. But then the secret can also be extracted from a binary.
CMAKE_BACKTRACE_URL: ${{ vars.SENTRY_PR_MINIDUMP_ENDPOINT }}
CMAKE_BACKTRACE_TOKEN: PR_${{ github.event.number }}_${{ github.sha }}
UPLOAD_BUCKET: overte-public