From 1f4116d2831ceb754184a4dde21afe9107985cae Mon Sep 17 00:00:00 2001
From: Dale Glass <dale@daleglass.net>
Date: Sat, 1 Jun 2024 20:08:55 +0200
Subject: [PATCH] Fix memory leak and memory overwrite. Closes #969

---
 tests/shared/src/BitVectorHelperTests.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/shared/src/BitVectorHelperTests.cpp b/tests/shared/src/BitVectorHelperTests.cpp
index c99c85d377..b7b5df32e5 100644
--- a/tests/shared/src/BitVectorHelperTests.cpp
+++ b/tests/shared/src/BitVectorHelperTests.cpp
@@ -34,7 +34,7 @@ static void readWriteHelper(const std::vector<bool>& src) {
     int numBits = (int)src.size();
     int numBytes = calcBitVectorSize(numBits);
     uint8_t* bytes = new uint8_t[numBytes];
-    memset(bytes, numBytes, sizeof(uint8_t));
+    memset(bytes, sizeof(uint8_t), numBytes);
     int numBytesWritten = writeBitVector(bytes, numBits, [&](int i) {
         return src[i];
     });
@@ -53,6 +53,8 @@ static void readWriteHelper(const std::vector<bool>& src) {
         bool b = dst[i];
         QCOMPARE(a, b);
     }
+
+    delete[] bytes;
 }
 
 void BitVectorHelperTests::readWriteTest() {