Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-04-05 21:12:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Review fix, change pointer to reference

Browse source
This commit is contained in:
Dale Glass 2023-07-09 20:19:36 +02:00
parent 69f1ddcec0
commit 0de10029f3
3 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/oven/src/OvenCLIApplication.cpp
View file

@ -38,7 +38,7 @@ OvenCLIApplication::OvenCLIApplication(int argc, char* argv[]) :
Q_ARG(QString, _outputUrlParameter.toString()), Q_ARG(QString, _typeParameter)); Q_ARG(QString, _outputUrlParameter.toString()), Q_ARG(QString, _typeParameter));
} }
OvenCLIApplication::parseResult OvenCLIApplication::parseCommandLine(int argc, char* argv[], bool *enableCrashHandler) { OvenCLIApplication::parseResult OvenCLIApplication::parseCommandLine(int argc, char* argv[], bool &enableCrashHandler) {
// parse the command line parameters // parse the command line parameters
QCommandLineParser parser; QCommandLineParser parser;
@ -71,7 +71,7 @@ OvenCLIApplication::parseResult OvenCLIApplication::parseCommandLine(int argc, c
} }
if (parser.isSet(forceCrashReportingOption)) { if (parser.isSet(forceCrashReportingOption)) {
*enableCrashHandler = true; enableCrashHandler = true;
} }
if (parser.isSet(versionOption)) { if (parser.isSet(versionOption)) {

15
tools/oven/src/OvenCLIApplication.h
View file

@ -26,7 +26,20 @@ public:
CLIMode CLIMode
}; };
static parseResult parseCommandLine(int argc, char* argv[], bool *enableCrashHandler); /**
* @brief Parses the command line arguments
*
* Oven can operate both in GUI and CLI mode. Depending on which arguments are passed,
* we pick the mode to use, and this function returns it.
*
* Both modes can have the crash handler enabled.
*
* @param argc argc
* @param argv argv
* @param enableCrashHandler Output parameter -- whether the crash handler should be enabled.
* @return parseResult Which application we should run
*/
static parseResult parseCommandLine(int argc, char* argv[], bool &enableCrashHandler);
static OvenCLIApplication* instance() { return dynamic_cast<OvenCLIApplication*>(QCoreApplication::instance()); } static OvenCLIApplication* instance() { return dynamic_cast<OvenCLIApplication*>(QCoreApplication::instance()); }

2
tools/oven/src/main.cpp
View file

@ -56,7 +56,7 @@ int main (int argc, char** argv) {
// figure out if we're launching our GUI application or just the simple command line interface // figure out if we're launching our GUI application or just the simple command line interface
bool enableCrashHandler = false; bool enableCrashHandler = false;
OvenCLIApplication::parseResult res = OvenCLIApplication::parseCommandLine(argc, argv, &enableCrashHandler); OvenCLIApplication::parseResult res = OvenCLIApplication::parseCommandLine(argc, argv, enableCrashHandler);
switch(res) { switch(res) {
case OvenCLIApplication::CLIMode: case OvenCLIApplication::CLIMode: