From 9a7de106142fe2f449985374451a4029a0a850d1 Mon Sep 17 00:00:00 2001
From: Roxanne Skelly <roxanne@highfidelity.io>
Date: Wed, 11 Sep 2019 16:27:00 -0700
Subject: [PATCH] set file permissions on the config.json file for the domain
 server

---
 domain-server/resources/web/js/domain-server.js   | 1 -
 domain-server/src/DomainServer.cpp                | 2 +-
 domain-server/src/DomainServerSettingsManager.cpp | 4 ++--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/domain-server/resources/web/js/domain-server.js b/domain-server/resources/web/js/domain-server.js
index 9524b18caf..a8b7267b88 100644
--- a/domain-server/resources/web/js/domain-server.js
+++ b/domain-server/resources/web/js/domain-server.js
@@ -91,7 +91,6 @@ $(document).ready(function(){
     // make a JSON request to get the dropdown menus for content and settings
     // we don't error handle here because the top level menu is still clickable and usables if this fails
     $.getJSON('/settings-menu-groups.json', function(data){
-
       function makeGroupDropdownElement(group, base) {
         var html_id = group.html_id ? group.html_id : group.name;
         return "<li class='setting-group'><a href='" + settingsGroupAnchor(base, html_id) + "'>" + group.label + "<span class='badge'></span></a></li>";
diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp
index 7f6c366bc3..307a43ee88 100644
--- a/domain-server/src/DomainServer.cpp
+++ b/domain-server/src/DomainServer.cpp
@@ -2718,7 +2718,7 @@ std::pair<bool, QString>  DomainServer::isAuthenticatedRequest(HTTPConnection* c
         QString cookieString = connection->requestHeader(HTTP_COOKIE_HEADER_KEY);
 
         QRegExp cookieUUIDRegex(COOKIE_UUID_REGEX_STRING);
-        
+
         QUuid cookieUUID;
         if (cookieString.indexOf(cookieUUIDRegex) != -1) {
             cookieUUID = cookieUUIDRegex.cap(1);
diff --git a/domain-server/src/DomainServerSettingsManager.cpp b/domain-server/src/DomainServerSettingsManager.cpp
index cc0f02ecda..73d78a5c70 100644
--- a/domain-server/src/DomainServerSettingsManager.cpp
+++ b/domain-server/src/DomainServerSettingsManager.cpp
@@ -1535,7 +1535,6 @@ QJsonObject DomainServerSettingsManager::settingsResponseObjectForType(const QSt
             }
 
             if (!groupKey.isEmpty() && !groupResponseObject.isEmpty()) {
-
                 // set this group's object to the constructed object
                 responseObject[groupKey] = groupResponseObject;
             }
@@ -1728,7 +1727,6 @@ bool DomainServerSettingsManager::recurseJSONObjectAndOverwriteSettings(const QJ
 
     postedObject[OAUTH_ROOT_KEY] = oauthObject;
 
-    qDebug() << postedObject;
     // Iterate on the setting groups
     foreach(const QString& rootKey, postedObject.keys()) {
         const QJsonValue& rootValue = postedObject[rootKey];
@@ -1913,6 +1911,8 @@ void DomainServerSettingsManager::persistToFile() {
         _configMap.loadConfig();
         return; // defend against future code
     }
+
+    QFile(settingsFilename).setPermissions(QFileDevice::ReadOwner | QFileDevice::WriteOwner);
 }
 
 QStringList DomainServerSettingsManager::getAllKnownGroupNames() {