From 7701710aa5e4241e7b98a06ddd434dcf2572d24c Mon Sep 17 00:00:00 2001
From: Simon Walton <simon@highfidelity.io>
Date: Wed, 19 Jun 2019 15:02:16 -0700
Subject: [PATCH] Consider a NetworkClipLoader resource with null URL to be
 failed

---
 libraries/recording/src/recording/ClipCache.cpp           | 8 +++++++-
 .../script-engine/src/RecordingScriptingInterface.cpp     | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/libraries/recording/src/recording/ClipCache.cpp b/libraries/recording/src/recording/ClipCache.cpp
index bc20e4d8eb..0fc65a2d79 100644
--- a/libraries/recording/src/recording/ClipCache.cpp
+++ b/libraries/recording/src/recording/ClipCache.cpp
@@ -18,7 +18,13 @@
 using namespace recording;
 NetworkClipLoader::NetworkClipLoader(const QUrl& url) :
     Resource(url),
-    _clip(std::make_shared<NetworkClip>(url)) {}
+    _clip(std::make_shared<NetworkClip>(url)) {
+    if (url.isEmpty()) {
+        _loaded = false;
+        _startedLoading = false;
+        _failedToLoad = true;
+    }
+}
 
 void NetworkClip::init(const QByteArray& clipData) {
     _clipData = clipData;
diff --git a/libraries/script-engine/src/RecordingScriptingInterface.cpp b/libraries/script-engine/src/RecordingScriptingInterface.cpp
index f3bcbe6bb7..e57d80274a 100644
--- a/libraries/script-engine/src/RecordingScriptingInterface.cpp
+++ b/libraries/script-engine/src/RecordingScriptingInterface.cpp
@@ -93,7 +93,7 @@ void RecordingScriptingInterface::loadRecording(const QString& url, QScriptValue
 
     // when clip load fails, call the callback with the URL and failure boolean
     connect(clipLoader.data(), &recording::NetworkClipLoader::failed, callback.engine(), [this, weakClipLoader, url, callback](QNetworkReply::NetworkError error) mutable {
-        qCDebug(scriptengine) << "Failed to load recording from" << url;
+        qCDebug(scriptengine) << "Failed to load recording from\"" << url << '"';
 
         if (callback.isFunction()) {
             QScriptValueList args { false, url };