bail early from irrecoverable retry situations

This commit is contained in:
humbletim 2016-11-06 09:40:28 -05:00
parent 2139e979da
commit 61452c21a2

View file

@ -202,7 +202,14 @@ void ScriptCache::scriptContentAvailable() {
finished = true; finished = true;
qCDebug(scriptengine) << "Done downloading script at:" << url.toString(); qCDebug(scriptengine) << "Done downloading script at:" << url.toString();
} else { } else {
if (scriptRequest.numRetries < MAX_RETRIES) { auto result = req->getResult();
bool irrecoverable =
result == ResourceRequest::AccessDenied ||
result == ResourceRequest::InvalidURL ||
result == ResourceRequest::NotFound ||
scriptRequest.numRetries >= MAX_RETRIES;
if (!irrecoverable) {
++scriptRequest.numRetries; ++scriptRequest.numRetries;
qDebug() << "Script request failed: " << url; qDebug() << "Script request failed: " << url;