From 426df9dc948031f218ef8a4078215e567b8335d7 Mon Sep 17 00:00:00 2001 From: HifiExperiments Date: Sat, 13 Apr 2024 14:13:44 -0700 Subject: [PATCH] conversionPenaltyScore should accumulate --- libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp b/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp index 177eeb259f..9409322e99 100644 --- a/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp +++ b/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp @@ -1027,7 +1027,7 @@ void ScriptMethodV8Proxy::call(const v8::FunctionCallbackInfo& argume } else { qVarArgLists[i].append(varArgVal); const QVariant& converted = qVarArgLists[i].back(); - conversionPenaltyScore = _engine->computeCastPenalty(V8ScriptValue(_engine, argVal), methodArgTypeId); + conversionPenaltyScore += _engine->computeCastPenalty(V8ScriptValue(_engine, argVal), methodArgTypeId); // a lot of type conversion assistance thanks to https://stackoverflow.com/questions/28457819/qt-invoke-method-with-qvariant // A const_cast is needed because calling data() would detach the QVariant.