Mirrors/overte-Armored-Dragon
3
0
Fork 0
mirror of https://github.com/Armored-Dragon/overte.git synced 2025-03-11 16:13:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Check for out-of-bounds in GLTFSerializer

Browse source
This commit is contained in:
ksuprynowicz 2024-02-25 22:19:05 +01:00
parent 081ae901d2
commit 351530055f
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libraries/model-serializers/src/GLTFSerializer.cpp
View file

@ -317,6 +317,11 @@ bool GLTFSerializer::buildGeometry(HFMModel& hfmModel, const hifi::VariantHash&
size_t matrixIndex = jointNodeIndex;
std::vector<float>& value = inverseBindValues[s];
size_t matrixCount = 16 * matrixIndex;
if (matrixCount + 15 >= value.size()) {
qDebug(modelformat) << "GLTFSerializer::buildGeometry: not enough entries in jointInverseBindTransforms: " << _url;
hfmModel.loadErrorCount++;
return false;
}
jointInverseBindTransforms[jointIndex] =
glm::mat4(value[matrixCount], value[matrixCount + 1], value[matrixCount + 2], value[matrixCount + 3],
value[matrixCount + 4], value[matrixCount + 5], value[matrixCount + 6], value[matrixCount + 7],