From 2355499ae110bdadf202d44277f75b5295237276 Mon Sep 17 00:00:00 2001 From: Brad Davis Date: Thu, 27 Dec 2018 18:16:03 -0800 Subject: [PATCH] Fix version code for android APKs --- android/build_android.sh | 4 ++-- android/containerized_build.sh | 23 ++++++++++++++--------- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/android/build_android.sh b/android/build_android.sh index f98bd1a4b2..189e6099a8 100755 --- a/android/build_android.sh +++ b/android/build_android.sh @@ -1,4 +1,4 @@ #!/usr/bin/env bash set -xeuo pipefail -./gradlew -PHIFI_ANDROID_PRECOMPILED=${HIFI_ANDROID_PRECOMPILED} -PRELEASE_NUMBER=${RELEASE_NUMBER} -PRELEASE_TYPE=${RELEASE_TYPE} setupDependencies -./gradlew -PHIFI_ANDROID_PRECOMPILED=${HIFI_ANDROID_PRECOMPILED} -PRELEASE_NUMBER=${RELEASE_NUMBER} -PRELEASE_TYPE=${RELEASE_TYPE} app:${ANDROID_BUILD_TARGET} \ No newline at end of file +./gradlew -PHIFI_ANDROID_PRECOMPILED=${HIFI_ANDROID_PRECOMPILED} -PVERSION_CODE=${VERSION_CODE} -PRELEASE_NUMBER=${RELEASE_NUMBER} -PRELEASE_TYPE=${RELEASE_TYPE} setupDependencies +./gradlew -PHIFI_ANDROID_PRECOMPILED=${HIFI_ANDROID_PRECOMPILED} -PVERSION_CODE=${VERSION_CODE} -PRELEASE_NUMBER=${RELEASE_NUMBER} -PRELEASE_TYPE=${RELEASE_TYPE} app:${ANDROID_BUILD_TARGET} \ No newline at end of file diff --git a/android/containerized_build.sh b/android/containerized_build.sh index cd6f15a92e..e5ec895146 100755 --- a/android/containerized_build.sh +++ b/android/containerized_build.sh @@ -9,14 +9,19 @@ docker run \ --rm \ --security-opt seccomp:unconfined \ -v "${WORKSPACE}":/home/jenkins/hifi \ - -e "RELEASE_NUMBER=${RELEASE_NUMBER}" \ - -e "RELEASE_TYPE=${RELEASE_TYPE}" \ - -e "ANDROID_BUILD_TARGET=assembleDebug" \ - -e "CMAKE_BACKTRACE_URL=${CMAKE_BACKTRACE_URL}" \ - -e "CMAKE_BACKTRACE_TOKEN=${CMAKE_BACKTRACE_TOKEN}" \ - -e "CMAKE_BACKTRACE_SYMBOLS_TOKEN=${CMAKE_BACKTRACE_SYMBOLS_TOKEN}" \ - -e "GA_TRACKING_ID=${GA_TRACKING_ID}" \ - -e "GIT_PR_COMMIT=${GIT_PR_COMMIT}" \ - -e "VERSION_CODE=${VERSION_CODE}" \ + -e RELEASE_NUMBER \ + -e RELEASE_TYPE \ + -e ANDROID_BUILD_TARGET \ + -e ANDROID_BUILD_DIR \ + -e CMAKE_BACKTRACE_URL \ + -e CMAKE_BACKTRACE_TOKEN \ + -e CMAKE_BACKTRACE_SYMBOLS_TOKEN \ + -e GA_TRACKING_ID \ + -e OAUTH_CLIENT_SECRET \ + -e OAUTH_CLIENT_ID \ + -e OAUTH_REDIRECT_URI \ + -e VERSION_CODE \ "${DOCKER_IMAGE_NAME}" \ sh -c "./build_android.sh" + +