Merge pull request #16110 from ctrlaltdavid/BUGZ-1357

BUGZ-1357: Fix crashes in ScriptDiscoveryService API
This commit is contained in:
Shannon Romano 2019-08-28 09:10:29 -07:00 committed by GitHub
commit e4bcbf60ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -78,13 +78,16 @@ TreeNodeBase* ScriptsModel::getTreeNodeFromIndex(const QModelIndex& index) const
}
QModelIndex ScriptsModel::index(int row, int column, const QModelIndex& parent) const {
if (row < 0 || column < 0) {
if (row < 0 || row >= rowCount(parent) || column < 0 || column >= columnCount(parent)) {
return QModelIndex();
}
return createIndex(row, column, getFolderNodes(static_cast<TreeNodeFolder*>(getTreeNodeFromIndex(parent))).at(row));
}
QModelIndex ScriptsModel::parent(const QModelIndex& child) const {
if (!child.isValid()) {
return QModelIndex();
}
TreeNodeFolder* parent = (static_cast<TreeNodeBase*>(child.internalPointer()))->getParent();
if (!parent) {
return QModelIndex();