Update DomainContentBackupManager to use emplace_back where available

This commit is contained in:
Ryan Huffman 2018-02-16 14:05:40 -08:00
parent 27c26bab86
commit 936629ec1a
2 changed files with 10 additions and 3 deletions

View file

@ -333,8 +333,8 @@ std::vector<BackupItemInfo> DomainContentBackupManager::getAllBackups() {
availabilityProgress += progress / _backupHandlers.size();
}
backups.push_back(
{ fileInfo.fileName(), name, fileInfo.absoluteFilePath(), createdAt, type == MANUAL_BACKUP_PREFIX });
backups.emplace_back(fileInfo.fileName(), name, fileInfo.absoluteFilePath(), createdAt,
type == MANUAL_BACKUP_PREFIX);
}
}
@ -343,7 +343,7 @@ std::vector<BackupItemInfo> DomainContentBackupManager::getAllBackups() {
void DomainContentBackupManager::getAllBackupsAndStatus(MiniPromise::Promise promise) {
if (QThread::currentThread() != thread()) {
QMetaObject::invokeMethod(this, "getAllBackupInformation", Q_ARG(MiniPromise::Promise, promise));
QMetaObject::invokeMethod(this, "getAllBackupsAndStatus", Q_ARG(MiniPromise::Promise, promise));
return;
}

View file

@ -25,6 +25,13 @@
#include <shared/MiniPromises.h>
struct BackupItemInfo {
BackupItemInfo(QString pId, QString pName, QString pAbsolutePath, QDateTime pCreatedAt, bool pIsManualBackup)
: id(pId)
, name(pName)
, absolutePath(pAbsolutePath)
, createdAt(pCreatedAt)
, isManualBackup(pIsManualBackup){};
QString id;
QString name;
QString absolutePath;