Merge pull request #1068 from daleglass/fix_resource_totals

Set resource total size to content size when using a qrc:// resource
This commit is contained in:
Kalila 2021-03-11 18:30:56 -05:00 committed by GitHub
commit 5e2cc4c4bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -794,8 +794,6 @@ void Resource::handleReplyFinished() {
{ "size_mb", _bytesTotal / 1000000.0 }
});
setSize(_bytesTotal);
// Make sure we keep the Resource alive here
auto self = _self.lock();
ResourceCache::requestCompleted(_self);
@ -809,6 +807,14 @@ void Resource::handleReplyFinished() {
}
auto data = _request->getData();
if (_request->getUrl().scheme() == "qrc") {
// For resources under qrc://, there's no actual download being done, so
// handleDownloadProgress never gets called. We get the full length here
// at the end.
_bytesTotal = data.length();
}
setSize(_bytesTotal);
emit loaded(data);
downloadFinished(data);
} else {