Mirrors/overte-AleziaKurdis
3
0
Fork 0
mirror of https://github.com/AleziaKurdis/overte.git synced 2025-04-16 18:18:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #15106 from NissimHadar/21559-increaseComparisonThreshold

Browse source 
Case 21559: increased threshold to 0.9999
This commit is contained in:
Sam Gateau 2019-03-08 08:43:30 -08:00 committed by GitHub
commit 11adb83f22
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tools/nitpick/src/AWSInterface.cpp
View file

@ -589,6 +589,7 @@ void AWSInterface::updateAWS() {
QProcess* process = new QProcess();
_busyWindow.setWindowTitle("Updating AWS");
connect(process, &QProcess::started, this, [=]() { _busyWindow.exec(); });
connect(process, SIGNAL(finished(int)), process, SLOT(deleteLater()));
connect(process, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this,

1
tools/nitpick/src/Downloader.cpp
View file

@ -52,6 +52,7 @@ void Downloader::downloadFiles(const QStringList& URLs, const QString& directory
#ifdef Q_OS_WIN
QProcess* process = new QProcess();
_busyWindow.setWindowTitle("Downloading Files");
connect(process, &QProcess::started, this, [=]() { _busyWindow.exec(); });
connect(process, SIGNAL(finished(int)), process, SLOT(deleteLater()));
connect(process, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this,

2
tools/nitpick/src/Nitpick.cpp
View file

@ -38,7 +38,7 @@ Nitpick::Nitpick(QWidget* parent) : QMainWindow(parent) {
_ui.plainTextEdit->setReadOnly(true);
setWindowTitle("Nitpick - v3.1.1");
setWindowTitle("Nitpick - v3.1.2");
clientProfiles << "VR-High" << "Desktop-High" << "Desktop-Low" << "Mobile-Touch" << "VR-Standalone";
_ui.clientProfileComboBox->insertItems(0, clientProfiles);

4
tools/nitpick/src/TestCreator.cpp
View file

@ -340,8 +340,10 @@ void TestCreator::finishTestsEvaluation() {
if (!_isRunningFromCommandLine && !_isRunningInAutomaticTestRun) {
if (numberOfFailures == 0) {
QMessageBox::information(0, "Success", "All images are as expected");
} else if (numberOfFailures == 1) {
QMessageBox::information(0, "Failure", "One image is not as expected");
} else {
QMessageBox::information(0, "Failure", "One or more images are not as expected");
QMessageBox::information(0, "Failure", QString::number(numberOfFailures) + " images are not as expected");
}
}

2
tools/nitpick/src/TestCreator.h
View file

@ -121,7 +121,7 @@ private:
const QString TEST_RESULTS_FOLDER { "TestResults" };
const QString TEST_RESULTS_FILENAME { "TestResults.txt" };
const double THRESHOLD{ 0.98 };
const double THRESHOLD{ 0.9999 };
QDir _imageDirectory;

3
tools/nitpick/src/TestRailInterface.cpp
View file

@ -352,6 +352,7 @@ void TestRailInterface::createAddTestCasesPythonScript(const QString& testDirect
) {
QProcess* process = new QProcess();
_busyWindow.setWindowTitle("Updating TestRail");
connect(process, &QProcess::started, this, [=]() { _busyWindow.exec(); });
connect(process, SIGNAL(finished(int)), process, SLOT(deleteLater()));
connect(process, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this,
@ -482,6 +483,7 @@ void TestRailInterface::addRun() {
QMessageBox::Yes | QMessageBox::No).exec()
) {
QProcess* process = new QProcess();
_busyWindow.setWindowTitle("Updating TestRail");
connect(process, &QProcess::started, this, [=]() { _busyWindow.exec(); });
connect(process, SIGNAL(finished(int)), process, SLOT(deleteLater()));
connect(process, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this,
@ -591,6 +593,7 @@ void TestRailInterface::updateRunWithResults() {
QMessageBox::Yes | QMessageBox::No).exec()
) {
QProcess* process = new QProcess();
_busyWindow.setWindowTitle("Updating TestRail");
connect(process, &QProcess::started, this, [=]() { _busyWindow.exec(); });
connect(process, SIGNAL(finished(int)), process, SLOT(deleteLater()));
connect(process, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this,